Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libs #314

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Update libs #314

merged 5 commits into from
Dec 12, 2023

Conversation

MiaAltieri
Copy link
Contributor

sumary

  1. update data interfaces lib to most recent version
  2. update mongodb provider lib to only set pertinent information for mongos applications
  3. update config server inteface lib to use best practices

delgod
delgod previously approved these changes Dec 12, 2023
View reviewed changes
@MiaAltieri MiaAltieri dismissed stale reviews from dmitry-ratushnyy and delgod via 18b798a December 12, 2023 16:17
delgod
delgod previously approved these changes Dec 12, 2023
View reviewed changes
@MiaAltieri MiaAltieri dismissed stale reviews from delgod and dmitry-ratushnyy via 843cf67 December 12, 2023 16:37
delgod
delgod previously approved these changes Dec 12, 2023
View reviewed changes
@MiaAltieri MiaAltieri force-pushed the update-config-lib branch 2 times, most recently from 7f0d1ff to 316cca0 Compare December 12, 2023 16:55
@MiaAltieri MiaAltieri mentioned this pull request Dec 12, 2023
Merged
juditnovak
juditnovak approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@juditnovak juditnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (with my limited level of understanding 😅

@MiaAltieri MiaAltieri merged commit 911eff7 into 6/edge Dec 12, 2023
19 checks passed
@MiaAltieri MiaAltieri deleted the update-config-lib branch December 12, 2023 20:47
dmitry-ratushnyy pushed a commit that referenced this pull request Dec 15, 2023
@MiaAltieri @dmitry-ratushnyy
Update libs (#314)
618db86 
### sumary
1. update data interfaces lib to most recent version
2. update mongodb provider lib to only set pertinent information for
mongos applications
3. update config server inteface lib to use best practices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juditnovak juditnovak juditnovak approved these changes

@delgod delgod delgod approved these changes

@dmitry-ratushnyy dmitry-ratushnyy dmitry-ratushnyy left review comments

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiaAltieri @delgod @juditnovak @dmitry-ratushnyy